chore: migrate TesterApp to `react-native-test-app` #629

szymonrybczak · 2024-05-26T18:06:39Z

TODO:

Make sure that Release mode works
Specify rest options through app.json e.g. New Architecture, build modes, schemas.

Summary

In this Pull Request I've migrated TesterApp to react-native-test-app.

Test plan

App should work in the same way as before.

vercel · 2024-05-26T18:06:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
repack-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2024 2:48pm

changeset-bot · 2024-05-26T18:06:42Z

⚠️ No Changeset found

Latest commit: 400213d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/TesterApp/android/settings.gradle

packages/TesterApp/android/gradle.properties

thymikee · 2024-06-03T11:55:15Z

packages/TesterApp/android/gradle.properties

 # Automatically convert third-party libraries to use AndroidX
 android.enableJetifier=true
+# Jetifier randomly fails on these libraries
+android.jetifier.ignorelist=hermes-android


AFAIK jetifier is no longer necessary for RN libraries as all moved on to AndroidX, isn't it?

this is inside of TesterApp, if we can disable jetifier then lets do it 🚀

if all libs are migrated what's blocking us from removing it from the template? :) probably backward compatability, i have no idea how long we should keep it 🤔

https://github.com/react-native-community/template/blob/cd5e21b702ef5c08c74796d19dd72bdb05775d17/template/android/gradle.properties#L24-L25

For reference: react-native-community/cli#1662

packages/TesterApp/app.json

packages/TesterApp/.watchmanconfig

jbroma · 2024-06-03T11:58:51Z

packages/TesterApp/android/gradle.properties

 # Automatically convert third-party libraries to use AndroidX
 android.enableJetifier=true
+# Jetifier randomly fails on these libraries
+android.jetifier.ignorelist=hermes-android


this is inside of TesterApp, if we can disable jetifier then lets do it 🚀

packages/TesterApp/app.json

jbroma · 2024-06-03T22:10:52Z

Needed to add a bootstrap HOC as a workaround for development - apparently anything done before registering the main component causes native modules initialization to fail for some reason?

tido64 · 2024-06-04T08:02:07Z

Needed to add a bootstrap HOC as a workaround for development - apparently anything done before registering the main component causes native modules initialization to fail for some reason?

@jbroma: Do you have repro steps? I reverted badea9d but it seems to work fine?

Android	iOS

jbroma · 2024-06-04T08:15:21Z

@tido64 hey, thanks for looking into this 🙏

did you restart the dev server after reverting the latest commit? This issue seems to only happen on the first load when the dev server needs to bundle everything from scratch. Here's some screenshots from the app without the latest commit:

During bundling	Finished bundling

packages/TesterApp/react-native.config.js

jbroma · 2024-06-04T09:16:08Z

@tido64 I've narrowed it down to a more specific scenario, here are steps to repro:

cd packages/TesterApp
# start a fresh instance of dev-server
pnpm start
# in a different pane/window
pnpm android

First load of the newly installed app should cause the issue as shown above upon finish bundling (the one with AsyncStorage being null)

I've also confirmed that iOS is unaffected, this is only on Android

jbroma · 2024-06-10T13:11:35Z

Both release modes are working now:

for iOS we first need to run pnpm bundle:ios and then do bundle exec pod install (inside ios dir) so that the release bundles get copied to the app properly. Important thing to note here is that after running pod install, the target is set to Debug, so it might needed to be changes to Release manually.
for Android: for assets to be properly picked up it's best that we clean first (or rebuild) and then run the app in release mode

The commands are quite long in package.json, we might want to pull some of that stuff out into separate files in scripts dir. Ideally all issues above could be included in release scripts so that we don't need to remember about that stuff.

cc @szymonrybczak

szymonrybczak · 2024-06-10T21:43:01Z

Added script:
→ pnpm run ios:release - should bundle and app in Release mode
→ pnpm run android:release - should bundle and app with ./assembleRelease

jbroma

GJ! small nits, except for that I think we finally got this ready to be merged 💪

packages/TesterApp/scripts/release.js

jbroma

LGTM 🎉

szymonrybczak requested a review from jbroma May 26, 2024 18:06

szymonrybczak force-pushed the feat/migrate-testerapp-to-rnta branch from 189ee24 to 3f068d0 Compare May 26, 2024 18:16

vercel bot had a problem deploying to Preview May 26, 2024 18:16 Failure

szymonrybczak commented May 26, 2024

View reviewed changes

packages/TesterApp/android/settings.gradle Show resolved Hide resolved

szymonrybczak force-pushed the feat/migrate-testerapp-to-rnta branch from 3f068d0 to dfcc3fd Compare May 26, 2024 18:57

vercel bot had a problem deploying to Preview May 26, 2024 18:57 Failure

szymonrybczak commented May 26, 2024

View reviewed changes

packages/TesterApp/android/gradle.properties Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview May 26, 2024 19:16 Failure

szymonrybczak changed the base branch from v5-preview to main May 26, 2024 19:34

szymonrybczak force-pushed the feat/migrate-testerapp-to-rnta branch from 9d17569 to 6ebfc80 Compare May 26, 2024 19:51

vercel bot deployed to Preview May 26, 2024 19:52 View deployment

szymonrybczak force-pushed the feat/migrate-testerapp-to-rnta branch from 6ebfc80 to dd9502c Compare May 26, 2024 20:01

vercel bot had a problem deploying to Preview May 26, 2024 20:02 Failure

vercel bot deployed to Preview May 27, 2024 09:51 View deployment

jbroma mentioned this pull request May 27, 2024

fix(android): allow for disabling bridgeless microsoft/react-native-test-app#2052

Merged

7 tasks

thymikee reviewed Jun 3, 2024

View reviewed changes

packages/TesterApp/app.json Outdated Show resolved Hide resolved

jbroma reviewed Jun 3, 2024

View reviewed changes

vercel bot deployed to Preview June 3, 2024 14:59 View deployment

vercel bot deployed to Preview June 3, 2024 21:04 View deployment

vercel bot deployed to Preview June 3, 2024 22:09 View deployment

tido64 reviewed Jun 4, 2024

View reviewed changes

packages/TesterApp/react-native.config.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview June 4, 2024 11:12 View deployment

vercel bot deployed to Preview June 4, 2024 16:35 View deployment

chore: lockfile

e7d2fc6

vercel bot deployed to Preview June 6, 2024 07:34 View deployment

feat: enable bridgeless for Android and iOS

ca11d95

vercel bot deployed to Preview June 6, 2024 07:35 View deployment

chore(android): remove jetifier

908ca3b

szymonrybczak marked this pull request as ready for review June 6, 2024 09:54

chore: update react-native-test-app to ^3.7.4

3e8a818

vercel bot deployed to Preview June 7, 2024 09:29 View deployment

feat: enable single app mode

366a270

vercel bot deployed to Preview June 7, 2024 11:17 View deployment

Merge remote-tracking branch 'origin/main' into test-app

486ac1e

vercel bot deployed to Preview June 7, 2024 13:27 View deployment

chore: configure release mode bundling paths

635320d

vercel bot deployed to Preview June 10, 2024 13:05 View deployment

vercel bot deployed to Preview June 10, 2024 21:42 View deployment

feat: add scripts to build app in release mode

d2f7f38

szymonrybczak force-pushed the feat/migrate-testerapp-to-rnta branch from 810d8a9 to d2f7f38 Compare June 10, 2024 21:57

vercel bot deployed to Preview June 10, 2024 21:57 View deployment

jbroma approved these changes Jun 10, 2024

View reviewed changes

packages/TesterApp/scripts/release.js Show resolved Hide resolved

packages/TesterApp/scripts/release.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview June 11, 2024 09:02 View deployment

jbroma requested changes Jun 11, 2024

View reviewed changes

packages/TesterApp/scripts/release.js Outdated Show resolved Hide resolved

chore: apply reviewers review

400213d

szymonrybczak force-pushed the feat/migrate-testerapp-to-rnta branch from 9cc593a to 400213d Compare June 11, 2024 14:48

vercel bot deployed to Preview June 11, 2024 14:48 View deployment

jbroma approved these changes Jun 11, 2024

View reviewed changes

jbroma merged commit 7fc5a6b into main Jun 11, 2024
5 checks passed

jbroma deleted the feat/migrate-testerapp-to-rnta branch June 11, 2024 15:00

okwasniewski mentioned this pull request Jun 25, 2024

fix: react-native-screens not building on visionOS software-mansion/react-native-screens#2210

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate TesterApp to `react-native-test-app` #629

chore: migrate TesterApp to `react-native-test-app` #629

szymonrybczak commented May 26, 2024 •

edited by jbroma

Loading

vercel bot commented May 26, 2024 •

edited

Loading

changeset-bot bot commented May 26, 2024 •

edited

Loading

thymikee Jun 3, 2024

jbroma Jun 3, 2024

szymonrybczak Jun 3, 2024

thymikee Jun 3, 2024

jbroma Jun 3, 2024

jbroma commented Jun 3, 2024

tido64 commented Jun 4, 2024 •

edited

Loading

jbroma commented Jun 4, 2024

jbroma commented Jun 4, 2024 •

edited

Loading

jbroma commented Jun 10, 2024

szymonrybczak commented Jun 10, 2024

jbroma left a comment

jbroma left a comment

chore: migrate TesterApp to react-native-test-app #629

chore: migrate TesterApp to react-native-test-app #629

Conversation

szymonrybczak commented May 26, 2024 • edited by jbroma Loading

TODO:

Summary

Test plan

vercel bot commented May 26, 2024 • edited Loading

changeset-bot bot commented May 26, 2024 • edited Loading

⚠️ No Changeset found

thymikee Jun 3, 2024

Choose a reason for hiding this comment

jbroma Jun 3, 2024

Choose a reason for hiding this comment

szymonrybczak Jun 3, 2024

Choose a reason for hiding this comment

thymikee Jun 3, 2024

Choose a reason for hiding this comment

jbroma Jun 3, 2024

Choose a reason for hiding this comment

jbroma commented Jun 3, 2024

tido64 commented Jun 4, 2024 • edited Loading

jbroma commented Jun 4, 2024

jbroma commented Jun 4, 2024 • edited Loading

jbroma commented Jun 10, 2024

szymonrybczak commented Jun 10, 2024

jbroma left a comment

Choose a reason for hiding this comment

jbroma left a comment

Choose a reason for hiding this comment

chore: migrate TesterApp to `react-native-test-app` #629

chore: migrate TesterApp to `react-native-test-app` #629

szymonrybczak commented May 26, 2024 •

edited by jbroma

Loading

vercel bot commented May 26, 2024 •

edited

Loading

changeset-bot bot commented May 26, 2024 •

edited

Loading

tido64 commented Jun 4, 2024 •

edited

Loading

jbroma commented Jun 4, 2024 •

edited

Loading